Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and improve semantic structure of home page #126

Conversation

yshng
Copy link
Collaborator

@yshng yshng commented Feb 24, 2025

  • Add <header>, <footer>, and <main> tags to the corresponding components.
  • Add <h1> to "Polis" at the top of the page.
  • Change remaining headers to <h2>
  • Change header tag used for emphasis to <strong> to signal importance.

Addresses both #60 and #61.

@yshng yshng linked an issue Feb 24, 2025 that may be closed by this pull request
@yshng
Copy link
Collaborator Author

yshng commented Feb 25, 2025

@thomassth @NewJerseyStyle Any insight into why this is failing the check?

@thomassth
Copy link

Possibly the cypress was listening for element types instead of content

@yshng
Copy link
Collaborator Author

yshng commented Feb 25, 2025

@thomassth Does this mean there isn't actually a problem and the PR can be approved? (barring any other issues with the code)

@thomassth
Copy link

The cypress test files should get some touchup I think o

@NewJerseyStyle
Copy link
Member

NewJerseyStyle commented Feb 25, 2025

Thanks @yshng 💖 I think it is fine, they are known issues. We will correct this misbehavior of E2E test on Thursday with @cplkake if he is available. We can wait for that patch first and then merge this by weekend.

@yshng yshng linked an issue Feb 25, 2025 that may be closed by this pull request
@NewJerseyStyle
Copy link
Member

Funny thing is, all tests passed on our local machine, so I'd merge this first and think about is later

@NewJerseyStyle NewJerseyStyle merged commit 634f0d4 into CivicTechTO:edge-civictechto Feb 27, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants