[CONTENT] Leader deputy patrols #2985
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like a lot of other miscellaneous changes were made to other patrols, were any outcomes/patrols removed? And if so, the reasoning? |
|
Ugh. my autoformatter strikes again. As far as I'm aware, these should all be whitespace related - no content changes. |
scribblecrumb
requested changes
Nov 23, 2024
| "values": ["platonic", "comfort"], | ||
| "amount": 5, | ||
| "log": [ | ||
| "Had a good patrol with {PRONOUN/m_c/poss} deputy", |
There was a problem hiding this comment.
My dear friend, ur missing periods on all these logs
…ce deputy-leader patrol
# Conflicts: # resources/dicts/patrols/general/training.json
# Conflicts: # resources/dicts/patrols/general/training.json
selkirks
requested changes
Dec 20, 2024
| "mutual": true, | ||
| "values": ["platonic", "trust", "comfort"], | ||
| "amount": 5, | ||
| "log": "m_c had a great play-fighting session with r_c when they were out on patrol together" |
There was a problem hiding this comment.
Missing period at the end of this log
| "art": "gen_train_warrior_rainy" | ||
| }, | ||
| { | ||
| "text": "Both r_c and p_l are positively bursting with things to discuss. Unfortunately, neither is particularly in the mood to sympathise with the other nor help solve their problems, so it descends into a prolonged kvetch. Whilst not inherently a bad thing, it does mean that both are a bit grumpy with each other by the time they return to camp.", |
There was a problem hiding this comment.
"sympathise" should be "sympathize"
| "art": "fst_hunt_heat" | ||
| }, | ||
| { | ||
| "text": "p_l is halfway through laying out the background of a particularly thorny problem when they are interrupted by another Clanmate springing through the undergrowth towards them. They're needed urgently back at camp! They race back as fast as their paws can take them, only to find that the so-called \"urgent issue\" is absurdly petty. p_l's claws dig into the earth, {PRONOUN/p_l/poss} annoyance poorly concealed.", |
There was a problem hiding this comment.
Most of this text needs to be pronoun tagged
| "mutual": true, | ||
| "values": ["platonic", "trust", "comfort"], | ||
| "amount": -10, | ||
| "log": "m_c feels like {PRONOUN/m_c/subject} was completely ignored when {PRONOUN/m_c/subject} tried to talk about important events with r_c on patrol." |
There was a problem hiding this comment.
'was' should be verb tagged
| "values": ["platonic", "romantic", "comfort", "trust"], | ||
| "amount": 10, | ||
| "log": [ | ||
| "Spent some time sunning with {PRONOUN/m_c/poss} mate r_c while on patrol", |
| "amount": 10, | ||
| "log": [ | ||
| "Spent some time sunning with {PRONOUN/m_c/poss} mate r_c while on patrol", | ||
| "Spent some time sunning with {PRONOUN/m_c/poss} mate r_c while on patrol" |
| ] | ||
| }, | ||
| { | ||
| "patrol_id": "gen_train_leaderdeputy_romance_1", |
There was a problem hiding this comment.
patrol needs a "relationship_constraint": ["mates"],
# Conflicts: # resources/dicts/patrols/general/training.json
…er-deputy-patrols
selkirks
requested changes
Dec 23, 2024
| }, | ||
|
|
||
| "weight": 40, |
There was a problem hiding this comment.
I'm assuming these blocks aren't actually changed and just Github funkiness, right?
| "mutual": false, | ||
| "values": ["respect", "trust"], | ||
| "amount": 10, | ||
| "log": "m_c was impressed by r_c's resourceful solutions to Clanmates' problems that were discussed while out on patrol" |
| "mutual": false, | ||
| "values": ["respect", "trust"], | ||
| "amount": 10, | ||
| "log": "m_c was grateful for r_c's support when {PRONOUN/r_c/subject} allowed {PRONOUN/m_c/object} to vent" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds two new training patrols, both for a 2 cat, leader and deputy situation. One is platonic, one is romantic. I personally send my leader and deputy together a lot and I think it's a bit of missed coverage that there's nothing specific to them. Every outcome has art attached & I have attempted to use the relationship log (development bug ticket incoming!).
Why This Is Good For ClanGen
More patrols are betterer!
Proof of Testing
Changelog/Credits
Two new leader-deputy patrols.