[CLEANUP] Refactoring of python files inside cats, cat_relations, and clan_resoucres folders #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oring not logical. reverting refactoring
…r_death_thought, load_thoughts
filvas2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
I have carefully gone though all .py files in the following path and tried to make the code cleaner where i deemed it suitable without changing the intent of the code.
Why This Is Good For ClanGen
I hope it will help with code readability and therefore maintainability
Linked Issues
Proof of Testing
I've also tested mediate relationships, kill the leader, break up and make mates of cats and other easily triggered events
Changelog/Credits
refactoring and code cleaning in the following folders: