fix mw with JobackIdeal

ClapeyronThermo · Jan 20, 2025 · 0f422be · 0f422be
1 parent bad674f
commit 0f422be
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/methods/methods.jl b/src/methods/methods.jl
@@ -62,6 +62,9 @@ end
 comp_molecular_weight(mw,z = SA[1.0]) = 0.001*dot(mw,z)
 molecular_weight(model) = molecular_weight(model,SA[1.0])
 molecular_weight(model::EoSModel,z) = __molecular_weight(model,z)
+molecular_weight(mw::AbstractVector,z) = comp_molecular_weight(mw,z)
+molecular_weight(mw::SingleParam,z) = comp_molecular_weight(mw.values,z)
+
 function __molecular_weight(model,z)
     MW = mw(model)
     if has_groups(model)

diff --git a/src/models/ideal/JobackIdeal.jl b/src/models/ideal/JobackIdeal.jl
@@ -148,7 +148,7 @@ The estimated critical point of a single component can be obtained via `crit_pur
 """
 JobackIdeal
 mw(model::JobackIdeal) = model.params.Mw.values
-molecular_weight(model::JobackIdeal,z) = molecular_weight(ReidIdeal(model),z)
+molecular_weight(model::JobackIdeal,z) = molecular_weight(model.params.Mw,z)
 function recombine_impl!(model::JobackIdeal)
     coeffs = model.params.coeffs
     i_groups = model.groups.i_groups
@@ -172,7 +172,7 @@ end
 function ReidIdeal(model::JobackIdeal)
     comps = model.components
     coeffs = model.params.coeffs
-    Mw = model.params.Mw,model
+    Mw = model.params.Mw
     a = SingleParam("a",comps,getindex.(coeffs.values,1))
     b = SingleParam("b",comps,getindex.(coeffs.values,2))
     c = SingleParam("c",comps,getindex.(coeffs.values,3))
@@ -183,6 +183,7 @@ function ReidIdeal(model::JobackIdeal)
     ReidIdeal(model.components,param,model.references)
 end
 
+
 """
     JobackGC