Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HANNA Model to v1.0.0 #315

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

se-schmitt
Copy link
Contributor

Update of HANNA to v1.0.0.

  • final version described in this paper
  • small modifications of documentation
  • additional tests

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (7b4fdb4) to head (691c684).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
lib/ClapeyronHANNA/src/ClapeyronHANNA.jl 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   87.65%   88.88%   +1.23%     
==========================================
  Files           2        2              
  Lines          81       90       +9     
==========================================
+ Hits           71       80       +9     
  Misses         10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@longemen3000
Copy link
Member

@se-schmitt is ok if i merge?

@se-schmitt
Copy link
Contributor Author

Yes, thanks!

@longemen3000 longemen3000 merged commit 210bac5 into ClapeyronThermo:master Nov 27, 2024
11 of 12 checks passed
@se-schmitt se-schmitt deleted the HANNA-v1.0.0 branch December 4, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants