[DEVX-814] Added request-id-prefix header to requests for usage monitoring #27
Conversation
mansi-k
changed the title
clarifaipyspark/client.py
Outdated
| @@ -23,6 +25,23 @@ def __init__(self, user_id: str, app_id: str, pat: str = None): | |||
| self.app = App(user_id=user_id, app_id=app_id, pat=pat) | |||
| super().__init__(user_id=user_id, app_id=app_id, pat=pat) | |||
|
|
|||
| @property | |||
| def metadata(self): | |||
There was a problem hiding this comment.
I'm not sure whether this will overwrite the SDK's header prefix, can you please confirm @srikanthbachala20
There was a problem hiding this comment.
Why would this overwrite SDK's header prefix? This is a separate library right? If not sure, @mansi-k you can check by using local python SDK and change the prefix to differentiate it from current requests and check on Datadog
There was a problem hiding this comment.
Then I don't think from this changes, its possible to change the REQUEST_ID_PREFIX from external library! We should be able to do that to track other frameworks where SDK is used
There was a problem hiding this comment.
+1 to the comments above. If we are wrapping over the python-sdk, then python-sdk needs to support this feature during initialization
| if pat: | ||
| self.metadata = (("authorization", "Key %s" % pat), (REQUEST_ID_PREFIX_HEADER, | ||
| REQUEST_ID_PREFIX)) |
There was a problem hiding this comment.
Why the PAT change? I see it was not there previously.
Also why do we add the prefix-header only when PAT is there? It should be added always?
https://clarifai.atlassian.net/browse/DEVX-814