Product/matanvax2/cad 25786 remove prepare int #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
matanvax2
force-pushed
the
Product/matanvax2/CAD-25786-remove-prepare-int
branch
14 times, most recently
from
9b5ee83 to
39f5456
Compare
| @@ -83,11 +83,11 @@ | |||
| " N_modulus: CInt,\n", | |||
There was a problem hiding this comment.
Why did you add the preferences? do you know if the optimization level affects the results?
Reply via ReviewNB
TomerGoldfriend
approved these changes
Jan 5, 2025
matanvax2
force-pushed
the
Product/matanvax2/CAD-25786-remove-prepare-int
branch
from
f9f6f96 to
c2e99f5
Compare
|
🚂 Fantastic work @matanvax2! Your very first PR to classiq-library has been merged! 🎉🥳 If you're feeling adventurous, why not dive into another issue and keep contributing? The Classiq community would love to see more from you! 🚀 Happy coding! 👩💻👨💻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Functions
prepare_intandinplace_prepare_intare going to be deprecated in the coming release. This PR eliminates their use in the library.