Added Server operations to License Generator #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these changes should be able to work with old licenses too.
Along with testing the
LicenseGenerator, making sure the Registration works would be good.I noticed that after successfully registering there are a few seconds on the
ProjectPickerwhere the user is told they don't own paratext. This is not unique to this branch, the same thing happens for me on main as well.The validation isn't perfect. I changed the
EmailValidatorto not accept # because that symbol was acting weird in the database.I got rid of the
LicenseKeyproperty in theUserclass because it doesn't make sense to be there. How can an object have a property where the contents of that property is an encrypted version of that object? It can't. InsteadLicenseKeywas moved to the newDashboardUserclass. Any places whereUserwas switched toDashboardUseris whereLicenseKeywas being used.