Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things were done to speed up Pins:
Running
GenerateData
in a Task.Run was really slow becauseGenerateData
had operations that required using the UIThread, thus putting that whole operation on the UIThread (which has other stuff to do) adding 30% more time. I broke up theGenerateData
method into smaller chunks and only ran operations that don't require the UIThread in Task.RunThere was some unnecessary looping and duplicate calls of
BookChapterVerseViewModel.GetBookNumFromBookName
in the area whereSortRefs
is used. I consolidated some loops and duplicate calls