Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speeding up pins again #706

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Speeding up pins again #706

merged 6 commits into from
Jul 11, 2023

Conversation

robertsonbrinker
Copy link
Contributor

@robertsonbrinker robertsonbrinker commented Jul 11, 2023

Two things were done to speed up Pins:

  1. Running GenerateData in a Task.Run was really slow because GenerateData had operations that required using the UIThread, thus putting that whole operation on the UIThread (which has other stuff to do) adding 30% more time. I broke up the GenerateData method into smaller chunks and only ran operations that don't require the UIThread in Task.Run

  2. There was some unnecessary looping and duplicate calls of BookChapterVerseViewModel.GetBookNumFromBookName in the area where SortRefs is used. I consolidated some loops and duplicate calls

@robertsonbrinker robertsonbrinker requested a review from GeoDirk July 11, 2023 14:29
@GeoDirk GeoDirk merged commit 078e23d into main Jul 11, 2023
@GeoDirk GeoDirk deleted the Speeding-Up-Pins-Again branch July 11, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants