initial ianitor version #1
Conversation
swistakm
assigned tomislater, mruwnik and trojkat and unassigned tomislater and mruwnik
| @@ -33,7 +33,7 @@ def get_version(version_tuple): | |||
| name='ianitor', | |||
| version=VERSION, | |||
| author='Michał Jaworski', | |||
| author_email='[email protected]', | |||
| author_email='[email protected]', | |||
|
I have fixed metioned issues. I have also updated project license and |
swistakm
force-pushed
the
feature/initial-ianitor
branch
from
fe0e3b9 to
2cca1b3
Compare
|
I have rebased it and pushed with |
| author='Michał Jaworski', | ||
| author_email='[email protected]', | ||
| author='Clearcode - The A Room', | ||
| author_email='[email protected]', | ||
| description='Doorkeeper for consul discovered services.', | ||
| long_description=README, |
There was a problem hiding this comment.
Remember that any package description that should be visible on pypi should be in restructured text than markdown. Otherwise pypi would display raw text.
There was a problem hiding this comment.
Yes I know that. I would like to leave it now in this form and maybe add some on-the-fly translation to restructured text on the setup.py upload stage as a separate feature.
Markdown is designed for good readability in verbatim so it's not a bad thing to have plain README.md on pypi.
Also I'm not a big fan of restructured text.
There was a problem hiding this comment.
@fizyk: I have updated setup.py to convert markdown to rst during package registration/upload.
Results can be seen here: https://pypi.python.org/pypi/ianitor
…escription using pypandoc
|
Does all approve this pull request? |
|
👍 though would like to see pep258 applied to docstrings ;) |
|
👍 where's the approve button? |
|
@trojkat there's none 😢 |
code for initial ianitor doorkeeper for easy dynamic registration of services within consul cluster