Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump python-consul version to 0.7.0 #16

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Bump python-consul version to 0.7.0 #16

merged 1 commit into from
Aug 2, 2017

Conversation

tomislater
Copy link

  • bump python-consul version to 0.7.0
  • add addon for python3.5 (Travis does not provide it itself now)
  • add Consul 0.8.5 to tests
  • change keep_alive method; now python-consul raises an exception

@tomislater
Copy link
Author

Who has access to Travis CI? I think, we should change some settings there.

@jotes
Copy link

jotes commented Jul 7, 2017

@tomislater #17 -> @swistakm is the maintainer of this repository & travis-ci.

@tomislater tomislater force-pushed the bump-consul-version branch from b6de72c to 6fefb2c Compare July 10, 2017 14:48
@coveralls
Copy link

coveralls commented Jul 10, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.4%) to 80.473% when pulling 6fefb2c on tomislater:bump-consul-version into 38c1e8f on ClearcodeHQ:master.

@tomislater
Copy link
Author

I am going to tidy this mess with my commits. I want to resolve the problem concerning Travis.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 80.473% when pulling aedae98 on tomislater:bump-consul-version into 38c1e8f on ClearcodeHQ:master.

2 similar comments
@coveralls
Copy link

coveralls commented Jul 10, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.4%) to 80.473% when pulling aedae98 on tomislater:bump-consul-version into 38c1e8f on ClearcodeHQ:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 80.473% when pulling aedae98 on tomislater:bump-consul-version into 38c1e8f on ClearcodeHQ:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.29% when pulling 777e973 on tomislater:bump-consul-version into 38c1e8f on ClearcodeHQ:master.

@tomislater tomislater force-pushed the bump-consul-version branch 5 times, most recently from 9aa6b83 to dbf0d02 Compare July 10, 2017 20:45
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.29% when pulling dbf0d02 on tomislater:bump-consul-version into 38c1e8f on ClearcodeHQ:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.29% when pulling dbf0d02 on tomislater:bump-consul-version into 38c1e8f on ClearcodeHQ:master.

swistakm
swistakm requested changes Jul 11, 2017
View reviewed changes
requirements.txt Outdated
@@ -1 +1 @@
python-consul==0.4.0
python-consul==0.7.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it makes sense to use less strict requirement like >=0.7.0,<0.8.0 assuming that there are no breaking changes in 0.7.x line.

Travis now supports cron jobs and I could setup one so we will be notified on any build errors if any python-consul update breaks backwards compatibility.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

.travis.yml Outdated
@@ -21,6 +21,12 @@ env:
- TOX_ENV=py34 CONSUL_VERSION=0.6.4
- TOX_ENV=py35 CONSUL_VERSION=0.6.4

# consul 0.8.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that the build matrix is already huge but we skipped 0.7.x release of consul (latest patch version is 0.7.5). If the list is too ling we can always get rid of 0.4.1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tomislater tomislater force-pushed the bump-consul-version branch from dbf0d02 to efc3239 Compare July 11, 2017 07:50
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.29% when pulling efc3239 on tomislater:bump-consul-version into 38c1e8f on ClearcodeHQ:master.

@tomislater
Bump python-consul version to 0.7.0
11e0e6c 
* add consul 0.8.5 and 0.9.0 to matrix on travis
@tomislater tomislater force-pushed the bump-consul-version branch from efc3239 to 11e0e6c Compare August 1, 2017 17:27
@tomislater
Copy link
Author

ping @swistakm

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.29% when pulling 11e0e6c on tomislater:bump-consul-version into 38c1e8f on ClearcodeHQ:master.

@swistakm swistakm merged commit 05ff1f6 into ClearcodeHQ:master Aug 2, 2017
@swistakm
Copy link
Collaborator

swistakm commented Aug 2, 2017

Released as 0.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swistakm swistakm swistakm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomislater @jotes @coveralls @swistakm