-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update arg_parser.py to fix --port
argument type
#6
Conversation
@@ -143,6 +143,7 @@ def get_parser(): | |||
|
|||
parser.add_argument( | |||
"--port", | |||
type=int, default=0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default 0
? I think it's not even possible to use such port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps there is no default value here, argument --port
still equals to 0
even leave it empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0 to 1023 are "well known ports" but there is no document that says 0 cannot be used and it has no official protocol assigned for neither TCP nor UDP. 0 is sometimes used (unofficialy) for specifying system allocated ports
build failed due to #4 |
someone could retry the build manually. I don't have such access rights anymore. |
can't reappear this test failure in local environment. |
I granted you access to ianitor back again. |
update arg_parser.py to fix `--port` argument type
Merged and released on PyPI as @pwilczynskiclearcode thanks for access grant! |
--port
argument defualt type isstr
, this will cause a consul register error.