Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include py.typed in MANIFEST.in #471

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Include py.typed in MANIFEST.in #471

merged 1 commit into from
Apr 19, 2023

Conversation

MaxwellPayne
Copy link
Contributor

@MaxwellPayne MaxwellPayne commented Apr 19, 2023

Fixes #470. This problem seems similar to one described in a similar httpx issue thread. Their ultimate solution led to a change to setup.py file, but since this project does not have a setup.py we can modify the MANIFEST.in instead to achieve the same results.

I ran the following commands, both before my change and after, to list out the results of the generated distribution:

python -m build . 
tar -xvf dist/pytest-redis-3.0.1.tar.gz 
ls -l pytest-redis-3.0.1/pytest_redis 

Final output before:

-rw-r--r--  1 max  staff   861 Apr 19 01:43 __init__.py
-rw-r--r--  1 max  staff  1527 Apr 19 01:43 config.py
-rw-r--r--  1 max  staff   343 Apr 19 01:43 exception.py
drwxr-xr-x  5 max  staff   160 Apr 19 01:46 executor
drwxr-xr-x  6 max  staff   192 Apr 19 01:46 factories
-rw-r--r--  1 max  staff  5021 Apr 19 01:43 plugin.py

Final output after:

-rw-r--r--  1 max  staff   861 Apr 19 01:43 __init__.py
-rw-r--r--  1 max  staff  1527 Apr 19 01:43 config.py
-rw-r--r--  1 max  staff   343 Apr 19 01:43 exception.py
drwxr-xr-x  5 max  staff   160 Apr 19 01:46 executor
drwxr-xr-x  6 max  staff   192 Apr 19 01:46 factories
-rw-r--r--  1 max  staff  5021 Apr 19 01:43 plugin.py
-rw-r--r--  1 max  staff     0 Apr 19 01:43 py.typed

The py.typed file is present in the "after" output as expected.

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_numer either from issue tracker or the Pull request number

@fizyk
Copy link
Member

fizyk commented Apr 19, 2023

Thank you @MaxwellPayne

@fizyk fizyk merged commit c1d3faa into ClearcodeHQ:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

py.typed not included in PyPI distribution
2 participants