Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from Vermut's 1st batch #28

Merged
merged 4 commits into from
Aug 19, 2022

Conversation

rfvermut
Copy link
Collaborator

@rfvermut rfvermut commented Aug 9, 2022

  • fix(soundmodule): female socket instead of male headers
  • fix(motorsensor): J10 was upside-down
  • feat(pcb): rotate J10 and move lower, soundboard pin sockets

@cianoflynn
Copy link

cianoflynn commented Aug 11, 2022

Hi,
J10 has to go the opposite direction of the adjacent J4?
J10_Fix

I took the original one out and want to make sure before I replace.

and the male audio module connector should be swapped for a female pin header?
Fix_Audio_MtoF

@rfvermut
Copy link
Collaborator Author

J10
This is how it supposed to look like
image

@rfvermut
Copy link
Collaborator Author

These two need to become females. Or at least start identify themselves as.
image

@cianoflynn
Copy link

Messed up a small bit with my fix. Should have just popped the plastic housing off the pins and flipped it around 180.

Only other thing I noticed was that 1 ground pin of the xESC2040 connectors at the edge needed some solder.

Besides that, boards look really nice. Thanks

@rfvermut
Copy link
Collaborator Author

Messed up a small bit with my fix. Should have just popped the plastic housing off the pins and flipped it around 180.

Can you tell me more? Do you mean there is a solderless way to fix it?

@cianoflynn
Copy link

cianoflynn commented Aug 14, 2022

Will have to check, I've orders some 2.0mm JST connectors and sockets from Ali. I only had the 2.54mm ones.
https://www.aliexpress.com/item/32908472053.html

(What's the name of that J10 connector type with the locking clip in the picture you posted showing the fix? May have ordered wrong sockets.)

245vs2wclip

My thinking was that the plastic could have been careful pried off the pins and flipped around to be in the right orientation. (Not sure this will work now since you said J10 has to be moved lower, maybe there is insufficient space. )
180socket It would be a very close fit.

If there's no space I can perhaps wire it like Clemen's board, with some wire to a socket.

headerfix

Copy link
Owner

@ClemensElflein ClemensElflein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Changes I noticed:

  • Rotated mower connector-
  • Some silkscreen changes (female pin headers, corner of neopixel)

@ClemensElflein ClemensElflein merged commit c63b286 into ClemensElflein:main Aug 19, 2022
@rfvermut rfvermut deleted the fix/vermut-1st-batch branch March 20, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants