Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rearrange/resort args #1376

Merged
merged 6 commits into from
Jan 11, 2024
Merged

refactor: rearrange/resort args #1376

merged 6 commits into from
Jan 11, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jan 9, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Groups args together to be less confusing, both for dev work and in the help menu.

I'll also do a pass on all the arg options and consolidate some of the arg + config code after this.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0f969fc) 32.37% compared to head (55f4e03) 32.83%.

Files Patch % Lines
src/options/args.rs 99.79% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
+ Coverage   32.37%   32.83%   +0.46%     
==========================================
  Files          98       98              
  Lines       17227    17348     +121     
==========================================
+ Hits         5577     5697     +120     
- Misses      11650    11651       +1     
Flag Coverage Δ
macos-12 34.71% <99.79%> (+0.49%) ⬆️
ubuntu-latest 34.43% <99.79%> (+0.47%) ⬆️
windows-2019 34.77% <99.79%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This groups together related arguments in both the help text and the
code itself.
@ClementTsang ClementTsang marked this pull request as ready for review January 10, 2024 08:50
@ClementTsang ClementTsang merged commit 6b62176 into main Jan 11, 2024
33 checks passed
@ClementTsang ClementTsang deleted the args_sorting branch January 11, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant