refactor(cc-grafana-info): avoid setting both disabled & waiting at the same time
#1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-grafana-info/fix-button-set-in-impossible-state/index.html. This preview will be deleted once this PR is closed. |
roberttran-cc
approved these changes
Jan 27, 2025
|
The only way I see to make test fail in that situation, is to write dedicated unit tests |
pdesoyres-cc
approved these changes
Jan 27, 2025
yeah I figured the same but it felt overkill 🤔 |
the same time Fixes #1124
florian-sanders-cc
force-pushed
the
cc-grafana-info/fix-button-set-in-impossible-state
branch
from
c151a15 to
d3f8688
Compare
florian-sanders-cc
deleted the
cc-grafana-info/fix-button-set-in-impossible-state
branch
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1124
Context
cc-grafana-infocomponent so thatdisabled&waitingare never set totrueat the same time. I simply forgot to handle this component in cc-button: avoid setting bothdisabled&waitingat the same time #1297.How am I sure no other components are missing?
The following log appears in local tests when there are issues of this type:
This time I ran all component tests locally and searched for the message to make sure there was none left.
Note: ideally I'd like these errors to make tests fails but I'm not sure how to do that at the moment? If you have ideas feel free to weigh in!
Note: this is a
refactorcommit and not afixbecause the issue it fixes has not been released yet.How to review?