Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basements on the 'newer' homes? #10612

Closed
EkarusRyndren opened this issue Dec 23, 2014 · 7 comments
Closed

Basements on the 'newer' homes? #10612

EkarusRyndren opened this issue Dec 23, 2014 · 7 comments
Labels
<Enhancement / Feature> New features, or enhancements on existing Map / Mapgen Overmap, Mapgen, Map extras, Map display <Suggestion / Discussion> Talk it out before implementing Z-levels Levels below and above ground.

Comments

@EkarusRyndren
Copy link
Contributor

Is there any reason the new, fancy looking homes don't generate basements? It seems like an oversight really but I'm more or less thinking outloud.

By "Newer" homes I'm referring to the various non cube five room homes that generate with something of a decorative layout and use of non-standard materials. Things like the stone house, the house with a pool, and so on.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@vache
Copy link
Contributor

vache commented Dec 23, 2014

No reason, other than they are "house" and not "house_base" with stairs down.

@KA101 KA101 added <Suggestion / Discussion> Talk it out before implementing <Enhancement / Feature> New features, or enhancements on existing labels Dec 23, 2014
@Snaaty
Copy link
Contributor

Snaaty commented Jan 2, 2015

Where are the basements even defined and where is it defined if/where they're supposed to spawn?

@BevapDin
Copy link
Contributor

BevapDin commented Jan 2, 2015

Overmap ares generated in overmap.cpp, the function house is used to return the overmap terrain representing a house, it returns "house_north" (no basement) or "house_base_north" (with basement) randomly.

The code later (in overmap::generate_sub) adds a "basement" terrain under the houses with a basement.

@vache
Copy link
Contributor

vache commented Jan 2, 2015

Houses with type "house_base" tell the game to place a basement under the house. When placing houses, the game selects about an even mix between houses with and without basements. Right now I think all the basements are hard coded in mapgen or mapgen_functions, and there exists no method to ensure a house always spawns with a given basement except for the special system, which doesn't spawn in town currently

@Snaaty
Copy link
Contributor

Snaaty commented Jan 2, 2015

I can't seem to find the said code in mapgen.cpp, are you sure it's there?

@KA101
Copy link
Contributor

KA101 commented Jan 2, 2015

all the basements are hard coded in mapgen or mapgen_functions

mapgen_functions.cpp is the way to go.

@illi-kun illi-kun closed this as completed Nov 6, 2016
@EkarusRyndren EkarusRyndren added Map / Mapgen Overmap, Mapgen, Map extras, Map display Z-levels Levels below and above ground. labels Nov 7, 2016
@illi-kun illi-kun reopened this Nov 18, 2016
@Leland
Copy link
Contributor

Leland commented May 4, 2017

Closing in favor of #15914 which more succinctly describes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Map / Mapgen Overmap, Mapgen, Map extras, Map display <Suggestion / Discussion> Talk it out before implementing Z-levels Levels below and above ground.
Projects
None yet
Development

No branches or pull requests

7 participants