Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #25244 #25248

Merged
merged 2 commits into from
Aug 30, 2018
Merged

Fix for #25244 #25248

merged 2 commits into from
Aug 30, 2018

Conversation

Shinino
Copy link
Contributor

@Shinino Shinino commented Aug 30, 2018

Summary

Balance "Adjust travois capacity and deer, sheep, fat zombie and bloated zombie size to allow for travois to work as expected with medium-sized corpses."

Purpose of change

Fixes #25244 -- deer, sheep, fat zombies and bloated zombies should not be the same 'size' as a cow or chicken walker. This is the reason that they cannot fit on a travois.

Describe the solution

Adjusted size from LARGE to MEDIUM on all four of these.

Describe alternatives you've considered

Originally, I considered changing the size on the travois itself from 200 to 400, giving it a volume of 100.0L (a large creature, in this case a deer, was 92.5L). That would resolve the issue, but have the unintended consequence of loading, say, a chicken walker onto a travois. Or any other large creature.

Given the relative size of a deer, sheep, fat zombie and bloated zombie compared to a) large mammals such as cows, horses, bears and moose and b) the relative size of a fat zombie and bloated zombie to a zombie brute the simplest change appeared to be to adjust the size of these four to be more in line with their actual size.

Additional context

Tested -- need to adjust travois size from 200 to 300 (75.0 L -- medium creature is 60ish L)

Travois currently has capacity of 50.0L.  A dead deer (size LARGE) has a volume of 92.5L -- as yes, it makes sense that you can load a dead deer on a travois.  Easiest (less impact to the game) change is to change the size of two mammals:  Sheep and Deer from LARGE to MEDIUM (neither weigh any more than a person) and two monsters (Fat Zombie and Bloated Zombies) -- if a zombie BRUTE is medium, there's no way either of these two should be anything but.
Adjusted travois size from 200 to 300, giving it a volume of 75.0L, enough to load a size MEDIUM corpse, but not much else.
@cainiaowu
Copy link
Contributor

cainiaowu commented Aug 30, 2018

We have mon_boomer /mon_boomer_fungus/ mon_boomer_huge both are LARGE.
Maybe mon_boomer and mon_boomer_fungus should change to MEDIUM too.

Edit: mon_zombie_corrosive is also large.

@Shinino
Copy link
Contributor Author

Shinino commented Aug 30, 2018

Eh. Boomers are significantly larger than even a fat-person zombie, based on what I recall from Left 4 Dead. I could see them being 700+ pounds, pushing 'Large' size.

@Shinino
Copy link
Contributor Author

Shinino commented Aug 30, 2018

Side note: Thinking about this, there are some medium monsters which can also be downgraded to small. Coyotes being a prime example, as they top out around 45lb. I'll poke at this more later.

@cainiaowu
Copy link
Contributor

Well, perhaps mon_boomer_huge can push up to HUGE?

@Regilith
Copy link
Contributor

I think @nexusmrsep is working on adding granularity to monster weights atm. Going around modifying flags might end up being wasted effort. See #24921 and #24909

@Rivet-the-Zombie Rivet-the-Zombie merged commit 8394b4f into CleverRaven:master Aug 30, 2018
@kevingranade
Copy link
Member

kevingranade commented Aug 30, 2018 via email

@Shinino
Copy link
Contributor Author

Shinino commented Aug 30, 2018

Well, if you lower the size of an animal/monster, it would lower the butchering yields, yes. I'll admit that it wasn't an intentional change, but is tied along with it. Kinda underscores the fact that sizes aren't...exactly clean and neat, so to say.

@Shinino
Copy link
Contributor Author

Shinino commented Aug 30, 2018

That said, a deer should not drop as much meat as a cow, either. Or a sheep.

@nexusmrsep
Copy link
Contributor

nexusmrsep commented Aug 30, 2018

@kevingranade its a problem of size granularity and weight being hard-coded derrivative of sizes and meat count being its derivative too, mentioned in recent issues. There is no space for ex. between human sized MEDIUM and a cow sized LARGE, so in result a 40kg SMALL (???) dog yields 1/3 of its weight in meat chunks. I pray that chihuahua was set to TINY, else it can rival a rottweiler in body mass. This PR by switching down one level of size to some smaller (mid size?) game is gracious, while there are some other more exagerated example where this lack of granuarity has stretched its usefullness. Give some guidelines where to go with untangling this problem and someone will pick it up. Cant remember issue number, but there is one, so if you can, please drop a comment.

@kevingranade
Copy link
Member

It sounds warranted, just wanted to make sure it wasn't accidental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travois don't carry enough volume!
6 participants