Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored selected item and extended win for long items name #36102

Closed
wants to merge 5 commits into from
Closed

Colored selected item and extended win for long items name #36102

wants to merge 5 commits into from

Conversation

8street
Copy link
Contributor

@8street 8street commented Dec 14, 2019

Summary

SUMMARY: Interface "Colored selected item and extended win for long items name"

Purpose of change

Now it’s very convenient to pick up items. Books are displayed in their color if there is only one item. Full and not cropped item names are also displayed.

Describe the solution

I'd created new window with full selected item text.
Since the game does not update its playing field when we picked items, I also fill the previous selected item in black if it exceeds the standard length of the item.

Describe alternatives you've considered

Testing

haha

haha1

Known issues

haha3

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Dec 16, 2019
@kevingranade
Copy link
Member

This is not an appropriate solution to the problem, the recoloring is fine, but arbitrarily extending a message past window borders is not ok.
This can scroll or adjust the size of the whole window.

@8street 8street deleted the colored_selected_item_and_extended_win_for_long_items_name branch December 27, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants