Migrate direct item spawns #37803
Merged
Migrate direct item spawns #37803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Items that are spawned using item groups aren't an issue since the contents of the groups get migrated on load. Direct spawning of items bypasses this migration. This commit applies migration to json mapgen definitions of direct item spawns and causes the migrated item to be spawned if need be.
ifreund
added
Spawn
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Migrate direct item spawns"
Purpose of change
Fixes #37372
Describe the solution
Items that are spawned using item groups aren't an issue since the
contents of the groups get migrated on load. Direct spawning of items
bypasses this migration.
This commit applies migration to json mapgen definitions of direct item
spawns and causes the migrated item to be spawned if need be.
Testing
Create a new world with generic guns.
Use the overmap editor to create the
mil_base_5e_northomt.Prior to this commit the game crashes on picking up the M4A1
With this commit applied, the generic guns assault rifle spawns instead and there is no crash.
Additional context
Thanks to @tenmillimaster for the reproduction case.