Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable explosives infrastructure #37838

Merged

Conversation

Brian-Otten
Copy link
Contributor

@Brian-Otten Brian-Otten commented Feb 8, 2020

Summary

SUMMARY: Infrastructure "Adds stable_explosive requirement and fixes some recipes"

Purpose of change

Explosives crafting still needed more infrastructure to let people add more recipes later in a scalable way. this adds the stable_explosives requirement for explosives that don't detonate easily, with them being 10g tnt equivalent each again.

I also discovered use of ammonium nitrate was a mess because of weird unit sizes, i standardized to 1g in this case for ease of use in explosive recipes specifically, since that will be the main usecase of the item.

Describe the solution

Adds stable_explosive requirement with suitable ingredients.
Add HMTD to volatile_explosive requirement. (overlooked possibility in last PR)
Standardize ammonium nitrate to 1g units and adjust all relevant recipes.
Standardize ANFO to 1g units and adjust relevant recipes.
Add ammonium nitrate pellets.
Allow converting of commercial fertilizer into ammonium nitrate pellets ( using the fertilizer directly would require changing fertilization code )
Allow grinding of ammonium nitrate pellets into powder.
Convert the fertilizer bomb to use new stable_explosive standard.

Describe alternatives you've considered

Rework use of fertilizer to allow use of commercial fertilizer in 1g portions in recipes directly (probably outside my skillset)

Testing

Game loads and all recipes work.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Feb 8, 2020
@Brian-Otten
Copy link
Contributor Author

Gave this a quick once over since 0.E and i don't see any issues right now, so should still be good to merge.

@ZhilkinSerg ZhilkinSerg merged commit b135675 into CleverRaven:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants