Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds copy-from to a bunch of books #37934

Closed
wants to merge 2 commits into from
Closed

[WIP] Adds copy-from to a bunch of books #37934

wants to merge 2 commits into from

Conversation

Geevies
Copy link
Contributor

@Geevies Geevies commented Feb 11, 2020

Summary

SUMMARY: Infrastructure "Adds copy-from to a bunch of books"

Purpose of change

Books didn't inherit looks from eachother, so tilesets that didn't have sprites for each book had symbols instead of a placeholder sprite. By adding copy-from, this problem will hopefully be alleviated.

Describe the solution

Doing copy-from should, in theory, grab the sprite from the abstracts. Using this means that a books hierarchy is created, which all pulls from the abstract.

Describe alternatives you've considered

Doing looks-like, which was my initial plan, actually. But doing copy-from from the specific abstracts has useful data in any case, so it seemed to be more useful than just grabbing the looks.

Testing

TO-ADD WHEN A SPRITE IS AVAILABLE

@Geevies
Copy link
Contributor Author

Geevies commented Feb 11, 2020

A recent interaction with a dev team member and project maintainer has left a sour taste in my mouth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant