Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new vehicle - "Survivor RV" #38927

Merged
merged 8 commits into from
Apr 11, 2020
Merged

Conversation

Pupsi-Mupsi
Copy link
Contributor

@Pupsi-Mupsi Pupsi-Mupsi commented Mar 21, 2020

Summary

SUMMARY: Content "Add Survivor RV"

Purpose of change

What would survivors use to travel safely from A to B?
A very rare and valuable RV was added that was previously in the hands of survivors.
It should be comfortable for five passengers and offers all types of vehicle extensions.


Hope you like it.

Screenshot(s)

V2

grafik

@anothersimulacrum
Copy link
Member

Could I suggest swapping the locations of the cargo containers and the beds, or otherwise modifying it so you don't have to crawl over containers to get through? I think it would be much easier/preferred to clamber over beds than cargo containers filled with stuff. Just my personal preference though.

@Pupsi-Mupsi
Copy link
Contributor Author

Pupsi-Mupsi commented Mar 21, 2020

Treating result as failure due to error logged during initialization.

Travis failed.
Could someone restart it?

@Pupsi-Mupsi
Copy link
Contributor Author

Could I suggest swapping the locations of the cargo containers and the beds, or otherwise modifying it so you don't have to crawl over containers to get through? I think it would be much easier/preferred to clamber over beds than cargo containers filled with stuff. Just my personal preference though.

Thanks for the feedback. I think it is important to have a closed sleeping area.

@anothersimulacrum
Copy link
Member

Restarting Travis will make it fail again, you need to fix the errors it's reporting.
https://travis-ci.org/github/CleverRaven/Cataclysm-DDA/jobs/665260670#L4656

@Pupsi-Mupsi
Copy link
Contributor Author

Could I suggest swapping the locations of the cargo containers and the beds, or otherwise modifying it so you don't have to crawl over containers to get through? I think it would be much easier/preferred to clamber over beds than cargo containers filled with stuff. Just my personal preference though.

Better?

chaosvolt added a commit to chaosvolt/nocts_cata_mod that referenced this pull request Mar 21, 2020
* Changed ID "surv_rv" to "c_surv_rv_military" due to
CleverRaven/Cataclysm-DDA#38927 using the same
ID in their newer vehicle addition.
* Also renamed the Survivior's RV to "Survivor's Militarized RV" to
ensue clarity.

Tested to ensure that this wouldn't break old saves.
@anothersimulacrum
Copy link
Member

Looks great!

@Cyrano7 Cyrano7 added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions labels Mar 22, 2020
@Aphegis
Copy link

Aphegis commented Mar 22, 2020

i think the spawn of this vehicle should be 10 times rarer.

@Pupsi-Mupsi
Copy link
Contributor Author

i think the spawn of this vehicle should be 10 times rarer.

Fine. There you go.

@Fris0uman
Copy link
Contributor

So there will be some fully kitted survivor RV chilling on the street from the start of the game, a few days after the cataclysm?
Wouldn't it make more sense to have this spawn in some specific location like survivor houses or LMOE shelters?

@Pupsi-Mupsi
Copy link
Contributor Author

Good thinking. I will prevent it from spawning in city areas and will reduce the spawnrate even further. So no bionic prepper will walk into it on day one ;-)

Also, as with most vehicles, it's not very likely to be fully functional. It could appear without batteries or surrounded by zombies. Players who have just started the game cannot benefit from this RV without the right recipes, tools and skills. It's nice to look at, but it won't break the game.

@Fris0uman
Copy link
Contributor

I'm more worried about the coherence of it than the balance. If the cataclysm was 5 or 6 days ago how come we already have survivor vehicles in cities. It might make more sense to have it where people would have started prepping in advance or something.

Alternatively having a timer to only make it spawn one month after the cataclysm for exemple would be good but that's outside the scope of this PR.

I will prevent it from spawning in city areas and will reduce the spawnrate even further.

That would make a bit more sense yeah

@Pupsi-Mupsi
Copy link
Contributor Author

Alternatively having a timer to only make it spawn one month after the cataclysm for exemple would be good but that's outside the scope of this PR.

A timer would indeed be a nice thing.

Pupsi-Mupsi added a commit to Pupsi-Mupsi/Cataclysm-DDA that referenced this pull request Mar 26, 2020
@kevingranade kevingranade merged commit 0692c0a into CleverRaven:master Apr 11, 2020
@Pupsi-Mupsi Pupsi-Mupsi deleted the PM-S-RV branch April 11, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants