Add extra .223 magazines #39156
Add extra .223 magazines #39156
Conversation
Linting
Fix mag capacities
|
I would consider making the 20 round magazine the default for the Mini-14, I don't think anyone really uses the flush 5 rounders unless they're legally obligated to for state gun laws or maybe hunting. Would maybe give the rifle some game life. (It looks like it's just a matter of putting it first in the compatible mags list?) Feel free to disagree. If you're doing the G36, maybe change the AUG to its own mags as well? They're plastic and come in 10, 30, and 42 rounds according to Steyr USA's website. I don't believe any sort of drum exists. I believe #38247 is handling the SIG 55x series. What does the mag_compact flag do? I see it missing from a couple of magazines that look like they should have it, namely the smaller Ruger ones and the standard G36 one. |
|
|
data/json/items/magazine/223.json
Outdated
| "looks_like": "stanag30", | ||
| "type": "MAGAZINE", | ||
| "name": { "str": "STANAG 42-round magazine" }, | ||
| "description": "An increased-capacity 40-round box magazine for use with STANAG compatible rifles.", |
There was a problem hiding this comment.
Description doesn't match capacity.
Fix error
Done.
Done. I added a 100-round double drum magazine for AUG too, though; apparently it does exist but is discontinued, so likely to be rare.
They are supposed to inherit that flag from the items they're copied from; I'll double-check if they really do, though. UPD: checked if magazines using copy-from can be stored in ammo pouches; turns out they can be, which means that this flag is correctly inherited. |
|
Could you provide clearer references to what you're basing the magazines off of? Mostly the 42, 50, 60, 100, and 150 round stanags. |
42-round STANAG: https://gunmagwarehouse.com/promag-ar-15-223-5-56-42-round-magazine.html |
|
For the 60-round mag, Surefire makes a 60-round version of that 100-round casket you linked. It's probably more well known and a bit more reliable than the ATI mag, and perhaps more importantly, it includes dimensions and unloaded weight in the listing. https://www.surefire.com/tactical-equipment/high-capacity-magazines/mag5-60.html The Magpul D60 is also a quite popular and seemingly reliable 60 round drum magazine. |
There was a problem hiding this comment.
Yeah, I don't think promag and KCI have that huge of a marketshare. Promag maybe, but their magazines are notoriously unreliable.
The 50 round drum is a copy of the X-15 50 rounder.
The 100 round drum is a copy of the old Beta-C magazine. (which had some reliability issues)
The Surefire casket are definitely known to be more reliable, but less so than the smaller drums. Magpul makes the D-60 as carmakazi mentioned.
The 90 round drum is the MWG 90 rounder?
The 42 round and 65 round magazines are very niche, I'd just drop those.
The 150 round drum can probably have a bump back up in reliability.
The 40 rounder should be based off the 40 rounder P-mags (since those are the most popular). Mat type would need to change to plastic+steel, and reliability can get a small bump.
The 100 round drum should be renamed to the Beta C. Mat type = plastic +steel.
The 50, probably renam to the X-15, or something similarly popular. Mat type = aluminum.
The 90, mat type is plastic+steel.
The 150 could get renamed to the SAW mag? Mat type = plastic+steel.
The 60 and 100 round caskets are both made of aluminum.
I'd personally keep the item names as-is. The Beta C company and X-products make their drums for several different guns and keeping the name would make it more clear what it is compatible with. His adding the names to the description is a good middle ground I think. |
|
Made changes are requested. And yeah, I decided to add specific names to descriptions instead; this is a minor detail for most players after all. Also added 60-round drum magazine and tried to adjust weight to be a bit more accurate. |
|
What about adding an adapter for g36 for stanags for instance? |
It's worth adding, but seems outside of scope of this PR (and it's already fairly large). Maybe I'll add it later. |
Summary
SUMMARY: Content "Add extra .223 magazines"Purpose of change
Add extra magazines that actually exist for .223 weapons; especially high-capacity double-drum magazines; added pretty much all magazines about which I could find some info that they really exist. Also change a few existing magazines a bit to be more consistent with the newly-added ones, and made G36 use non-STANAG magazines.
Describe the solution
JSON editing.
Describe alternatives you've considered
None.
Testing
Made sure that game starts up with no errors with those additions.
Additional context
Weight, volume, price and spawn frequency for new magazines are for the most part eyeballed; any suggestions on those are welcome.