Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate shelter types #39427

Merged

Conversation

capSAR273
Copy link
Contributor

@capSAR273 capSAR273 commented Apr 9, 2020

SUMMARY

SUMMARY: Content "Split vandalized shelter into a separate location category"

Purpose of change

Fixes #39393
This will allow the player to decide if they don't want to start in a vandalized shelter. If a random location is chosen, any variant of the shelter can be spawned.

Describe the solution

I split the vandalized shelter into its own type of building, giving it the same 3 variants as the clean/used shelter. If the player wants, they can still pick any kind of shelter variant, so any of the three can spawn as their starting location.

Describe alternatives you've considered

I considered removing the vandalized shelter altogether, but it should still remain in for those that want a more difficult Evacuee start.

Testing

I tested choosing the vandalized shelter and made sure all 3 variants were truly vandalized when they spawned. No intact doors/windows here! I also tested the base/used variant of the shelter to make sure no vandalized version spawned.

Menu option:
image

Additional context

N/A

@Pupsi-Mupsi
Copy link
Contributor

Would you mind changing your SUMMARY?

SUMMARY: Content "Split vandalized shelter into a separate location category"

@Pupsi-Mupsi
Copy link
Contributor

And lint (data/json/mapgen/shelter.json):
http://dev.narc.ro/cataclysm/format.html

@capSAR273 capSAR273 changed the title [CR] Separate shelter types Separate shelter types Apr 10, 2020
@ZhilkinSerg ZhilkinSerg added the Map / Mapgen Overmap, Mapgen, Map extras, Map display label Apr 14, 2020
@kevingranade kevingranade merged commit 5738946 into CleverRaven:master Apr 18, 2020
@Brian-Otten
Copy link
Contributor

No more restarting my game to have a reasonable chance of finding the refugee shelter. Excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Evacuee Start into Broken and Intact
5 participants