Adds new barrel bombs. obsoletes old explosive charges. #39492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brian-Otten
changed the title
|
Same as other PRs, would be nice if the descriptions specified the exact time to detonation. |
|
Added the 100 second time to detonation in the descriptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Adds more craftable barrel bombs. obsoletes explosives charges.'"Purpose of change
Crafting of explosives is a bit of a mess with a ton of options using specific ingredients, the goal is to genericize the recipes and use the new infrastructure that's in place. this should make crafting them in game less of a hassle, and contributing new explosives in the future should be much easier for devs.
Describe the solution
Adds improvised, and bootleg barrel bombs using new explosives infrastructure.
These are made using ANFO (and ilk) and military explosives respectively.
Obsoletes Anfo charge and rdx charge and recipes.
Testing
Load up a world and spawn some anfo charges and rdx charges. activate some.
Merge this PR
No crashes/bugs from the now obsolete charges
Craft the 2 new barrel bombs.
Barrel bombs work and explode as intended.
Additional context