Fixes Frost Armor spell from Magiclysm mod #39512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, let me know when you're done with it. i won't merge it with the WIP tag because that means you still want to work on it. |
KorGgenT
added
<Bugfix>
VitorHP
changed the title
|
If the Frost Armor values are good, then we're good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixes Frost Armor spell from Magiclysm mod."Purpose of change
fixes #39468 - Frost Armor was having no effect when cast.
Describe the solution
Changed Frost Armor's effect to spawn_item and created a Frost Armor item.
Describe alternatives you've considered
I've considered modifying the effect that was being used, but based on other similar spells, I decided to stick with spawn_item for consistency.
Testing
Casting Frost Armor now adds a Frost Armor item to the target.
Additional context
I'm not sure about the values of the Frost Armor item. I tried to eyeball what I thought was reasonable, but since I'm new to the game, my perceptions might be twisted.
I've tried setting a negative value to warmth, but the game told me it was an invalid value. I think this is something to be considered since some materials actually drain warmth from you instead of giving it.