Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Travis clang-tidy job #39537

Merged
merged 2 commits into from
Apr 13, 2020

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Remove Travis clang-tidy job"

Purpose of change

We have a better place to run our clang-tidy CI now, so remove the Travis one and the workarounds it entailed.

Describe the solution

Delete job from .travis.yml.

Remove time limit feature that prevented us from running all files through clang-tidy (GitHub has a 6 hour time limit, so this should no longer be needed).

Describe alternatives you've considered

Increasing the time limit rather than removing it.

Testing

Needs to be tested here on the CI.

We have one on GitHub now, which should be better due to a longer
timeout.
GitHub has a much more generous time limit, so we should no longer need
this 15 minute limit on clang-tidy jobs.
@jbytheway jbytheway changed the title Remove travis clang tidy Remove Travis clang-tidy job Apr 13, 2020
@ZhilkinSerg ZhilkinSerg added the Code: Build Issues regarding different builds and build environments label Apr 13, 2020
@kevingranade kevingranade merged commit 4c795f5 into CleverRaven:master Apr 13, 2020
@jbytheway jbytheway deleted the remove_travis_clang_tidy branch April 14, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants