Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add achievements tab to score window #39540

Merged
merged 3 commits into from
Apr 14, 2020

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: Interface "Add achievements tab to score window"

Purpose of change

Players should to be able to see the new achievements feature, and their progress towards achievements.

Describe the solution

Add a new tab to the scores UI. I made it the first tab, because I hope it will soon be the most interesting.

It's fairly simple, it simply lists each achievement together with its requirements. They are coloured according to their status.

Testing

Looking at the window in-game, and a small unit test.

Additional context

When pending:
achievement-window-pending
When complete:
achievement-window-complete

Some features aren't obvious here:

  • Each requirement is coloured independently.
  • The incomplete achievements are all sorted before the complete ones, but then sorted by translated description within that. Longer term, I plan to permit each achievement to have a sort key in json to control its sort order, so that similar achievements can appear together.

@ZhilkinSerg ZhilkinSerg added <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Apr 14, 2020
@ZhilkinSerg ZhilkinSerg merged commit 06514d0 into CleverRaven:master Apr 14, 2020
@jbytheway jbytheway deleted the achievements_ui branch April 14, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants