Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force link gettext on macOS for travis-ci #39549

Closed

Conversation

ralreegorganon
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Fix the travis-ci build for macOS.

Describe the solution

Stop trying to force link gettext and set the variables as instructed by brew instead.

Testing

This PR is the test--we'll see if it builds now.

@kevingranade
Copy link
Member

git timeout on the Mac test, COME ON Travis.

@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments OS: macOS Issues related to macOS / OSX operating system labels Apr 14, 2020
build-scripts/build.sh Outdated Show resolved Hide resolved
@ralreegorganon ralreegorganon marked this pull request as draft April 14, 2020 16:45
@ralreegorganon
Copy link
Contributor Author

Closing in favor of #39569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments OS: macOS Issues related to macOS / OSX operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants