Improve json linter log readability #39597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Build "makes json linter feedback more readable"Purpose of change
Personal peeve: "Unformatted" always sounds to me like "this file is not formatted correctly". Also inconsistency in positioning of the filename made it harder to scan the log for problems.
Describe the solution
Screenshot:
Describe alternatives you've considered
Dealing with it.
Testing
Messed up the formatting in a file & ran
make style-jsonAdditional context
This may be a shitty/clumsy/non-cross-platform way to do this (I don't know if the isatty check works in windows/macos/whatever, or at all). If there's a better way let me know and I'll fix it.