Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add music fluff items #39606

Merged
merged 3 commits into from
Apr 20, 2020
Merged

add music fluff items #39606

merged 3 commits into from
Apr 20, 2020

Conversation

KorGgenT
Copy link
Member

Summary

SUMMARY: Content "add music fluff items"

Purpose of change

wist was making a band space nested map, and i took it upon myself to add a few items that you would find in such a place. additional places you would find these items: A/V warehouse/closet, recording studio

Describe the solution

Adds some music fluff items like xlr cables, mic stands, and a mixer. None of these items have disassembly recipes right now, but I encourage someone else to do that if they wish for these items to do anything. (specifically the mixer can have some electroniocs in it)

Describe alternatives you've considered

going acoustic

Testing

made sure the game loaded without debug messages

@KorGgenT KorGgenT added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Apr 16, 2020
@KorGgenT KorGgenT requested a review from curstwist April 16, 2020 12:58
@curstwist
Copy link
Contributor

Looks good to me, I'm not experienced with item creation much though. It'd be nice if we could use the headphones, or have them wearable with a slight noise reduction. Maybe a future PR.

Copy link
Contributor

@curstwist curstwist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see comment on conversation page.

@Mecares
Copy link
Contributor

Mecares commented Apr 16, 2020

Wait a second, we can use the greek alphabet as symbols? Omega is amazing for head phones great idea! If that is the case maybe a big gamma Γ could be better for the microphone stand.

@KorGgenT
Copy link
Member Author

oh i didn't think of that, great idea!

@ZhilkinSerg ZhilkinSerg merged commit c78316a into CleverRaven:master Apr 20, 2020
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request Apr 20, 2020
@KorGgenT KorGgenT deleted the music-fluff branch August 13, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants