Clang-tidy readability-redundant-declarations #39702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously trigdist was declared in line.h and game.h but defined in options.cpp. Make it be declared in line.h and defined in line.cpp. This is consistent, and it fixes a readability-redundant-declaration warning from clang-tidy.
jbytheway
force-pushed
the
clang_tidy_readability_redundant_declarations
branch
from
304f983 to
7e2b48e
Compare
|
CI found an unrelated |
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
More static analysis.
This check looks for redundant declarations.
Describe the solution
Remove one redundant declaration.
Consolidate two declarations into one in a new place.
Testing
Unit tests only.
Additional context
Down to 32 clang-tidy checks to triage after this one.