Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only slip while climbing if terrain is unstable #39705

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

wapcaplet
Copy link
Contributor

@wapcaplet wapcaplet commented Apr 18, 2020

Summary

SUMMARY: Bugfixes "Allow climbing stairs without any chance of falling"

Purpose of change

Fixes #39701

Describe the solution

Move the slip_down() call in vertical_move inside the check for UNSTABLE terrain, so it only occurs when trying to climb unstable things.

Describe alternatives you've considered

Leaving "experimental" z-levels off and being perpetually confused

Testing

Attempted to climb a downspout 15-20 times, and slipped down 2 times.

Attempted to climb stairs 50+ times and always succeeded.

Instead of always having a chance to slip while climbing up, only have a
chance to slip if terrain is unstable (like a downspout, not stairs).

Fixes CleverRaven#39701
@kevingranade kevingranade merged commit ba80aa9 into CleverRaven:master Apr 19, 2020
@wapcaplet wapcaplet deleted the stable-stairs branch April 24, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You now slip while walking up stairs
2 participants