Update materials for bullet damage type #40112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
ymber
reviewed
May 4, 2020
| @@ -39,7 +39,7 @@ | |||
| "coverage": 85, | |||
| "encumbrance": 10, | |||
| "warmth": 15, | |||
| "material_thickness": 20, | |||
| "material_thickness": 16, | |||
There was a problem hiding this comment.
This is wrong. ESAPI plates are 20mm thick on the lowest end.
There was a problem hiding this comment.
Is that what material thickness is supposed to represent? I was under the impression it's a magic number for determining armor values. If that is not so, ceramic or nylon need changes to prevent this from getting a buff if that is changed back.
There was a problem hiding this comment.
Just to outline how I see this working real quick, I'd like to standardize on a physical thickness measurement (ideally with units etc), and then we loop back and have some unit tests where we essentially recreate various ballistic acceptance testing procedures like, "this will block 3 rounds of 9mm Parabellum".
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
With #38912 merged, materials need updating for proper bullet resistances.
Describe the solution
Update materials, and some clothes to match with the values determined on this spreadsheet.
Armor requiring crafting recipe updates (survivor gear) were left out of these changes.
Testing
Tests run, with changes from #40111 applied.
Can inspect various changed armors and see they have the new values: