Fix impossibility of crit with powerless firearms

[wwkk222208]

Summary

None

Purpose of change

When I was testing my PR, I found that I couldn't hit the hulk on the head with a 7.62 caliber gun. I tried to check the relevant code and found that if the damage of a single shot does not exceed the max hp of the target's head, then this shot will not hit the head. I don't know if the author of this code has a special intention, but I think this is very unreasonable. So I decide to modify it.

Describe the solution

Remove the restriction that it is possible to hit the head and crit only when the damage is high enough.

Describe alternatives you've considered

Testing

Shoot a hulk with a 7.62 caliber gun, and it can get 'headshot' and crit.

Additional context

[Alex-Folts]

Looking at git blame, there was similar PR: #46455 which was reverted by this commit: John-Candlebury@c23adf7

Seems like this is intentional behavior.

[wwkk222208]

Perhaps the author believes that mosquito bites should not be critically hit, which is is understandable.
But at least mosquitoes can bite the head. lol

[wwkk222208]

I checked the PR and the subsequent revert, the purpose of revert seems to be to prevent world_modifier from being calculated twice.

[waveyl]

#39203 seems to be relevant.

[kevingranade]

Hitting the head or not is a cosmetic issue, the goal here is that you need sufficient damage/penetration to reach vitals with a strike or projectile, this behavior is fully intentional.
This is mitigated somewhat with the weak point system, which models things like hitting an eye or similar to allow easier penetration.

[wwkk222208]

Hitting the head or not is a cosmetic issue, the goal here is that you need sufficient damage/penetration to reach vitals with a strike or projectile, this behavior is fully intentional.
This is mitigated somewhat with the weak point system, which models things like hitting an eye or similar to allow easier penetration.

Well, that seems to be good too.
But even if it doesn't hit critically, the projectile should be able to hit the head. @kevingranade

[kevingranade]

If it's not doing extra damage it doesn't matter where it hits, again, it's cosmetic.
A "headshot" is a special exception where it calls out where the target is hit, if it's a non-critical hit-to-the-head it's no longer that special case and it will be confusing to call it out differently.
It's possible weak points are not interacting with the crit code in such a way as to make what I sketched out happen, if so fixing that would be nice.

[wwkk222208]

In some cases, it is more than just cosmetic. For example, feral human will never hit the head of a player with a fragile skull.

A non-critical hit-to-the-head can be displayed as a normal good hit, so that it won’t confuse the player

[kevingranade]

It IS displayed as a good hit.