Fix potential nullptr crash when crafting #57587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furniture with a bugged pseudo inside causes problems
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix potential nullptr crash when crafting"
Purpose of change
Fixes #57543
Crafting with furniture that has a bugged pseudo item inside would lead to a nullptr crash. Smoker is especially troublesome because the bugged item(s) cannot be removed.
Describe the solution
Check that ammo pointer exists before using it.
Describe alternatives you've considered
The pseudo items ideally also need to be eradicated as they should not be there. The problem with the smoker is the tile cannot be interacted with other than through the smoker menu; they cannot be removed.
Testing
Crafting with attached save game linked by issue.
Before: any crafting with the smoker caused a crash.
After: crafting with smoker completes with no errors.
Additional context
The bug causing the pseudo items is likely fixed but I am not 100% convinced.