inv_ui: never hide entries in the selection column #64720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
andrei8l
force-pushed
the
selection-no-hide
branch
from
b8dd272 to
d115663
Compare
github-actions
bot
added
astyled
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The selection column in inventory UIs sometimes hides entries but it shouldn't.
Describe the solution
Set the override so the selection column never hides entries. Also slightly change the debugmsg path to make sure it doesn't crash the game if it ever happens again.
Describe alternatives you've considered
N/A
Testing
Before: hidden item from collapsed container, revealed by filter, was selected but didn't show up in the selection column. Toggling it again leads to a debug message and crash.
After: the selection column sees all
Additional context
N/A