Automatically request review regardless of reviewers' collaborator status #66072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Code: Tooling
github-actions
bot
added
astyled
github-actions
bot
added
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Second attempt at #65838. The codeowner file requires reviewers to have write access to the repo to be requested for review, which isn't what we actually want to achieve with it.
Describe the solution
Use a modified version of auto-request-review to ping non-collaborators for review.
Describe alternatives you've considered
Deal with Github's arbitrary restriction.
Testing
Tested in Qrox#14 and Qrox#15.
Additional context
The original auto-request-review repo has some documentation on how to configure reviewers. It uses minimatch to match file names which seems pretty versatile.
Based on my understanding of its code though, the random reviewers and limit reviewers functions probably won't work correctly, because it may select a different set of reviewers after updating a PR, even before my modifications.
The action also does not rerun when the base branch of a PR changes, but since most PRs are made to the master branch or another branch that is never force pushed, it probably does not actually matter.