Parametrize carpets in basement nests #77210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
|
Thank you for doing this. Parametrizing stuff makes a huge difference in how the game looks and feels. |
github-actions
bot
removed
the
BasicBuildPassed
github-actions
bot
added
the
BasicBuildPassed
|
Drafted this for now since I'm not happy with where I implemented the new palette, which I remedied in #77273, so I'm holding off on this one until that pr is merged. |
|
Merged this branch with #77287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Basement nest carpets have variation"
Purpose of change
I thought nests always having the same color of carpet becomes a bit bland over time, so made it so carpets can have different colors. If more carpets ever get added it will also be easier to add them.
Describe the solution
Added a new palette
standard_domestic_carpet_paletteand apply where relevant. I tried to avoid changing out areas where the carpet was chosen for aesthetic reasons, or at least seemed like it was.Describe alternatives you've considered
Not do this and always have the same carpets
Testing
Game loads, carpets change, furniture has correct flooring, carpets which shouldn't change don't.
Additional context
I had a lot of trouble with the parameter here because it only seems to work with
"scope": "nest", I'm unsure if I did something wrong or this is intended.I'm also planning on looking over most of the other nests and maybe buildings in general, but in order to keep the size of the pr down I thought I'd get this one out first.
Draft for now since #77208 needs to merge first