Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no debugging distractions #77332

Closed

Conversation

Kamejeir
Copy link
Contributor

Summary

None

Purpose of change

Already getting Debug Invincibility and Debug Life Support combined, means you have no use worrying about distractions. This will save keypresses.

Describe the solution

Add checks to disable every type of distraction when do_debug_quick_setup() is called.

Describe alternatives you've considered

Testing

My "Debug Debugson" loads into the world, with all distractions disabled.

Additional context

Please help me make it less ugly if possible.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 25, 2024
@RedMisao
Copy link
Contributor

In case I'm understanding, this will make it so you don't receive messages while in the debug state.
What if you do require receiving those messages for testing the thing, though? Such as when testing a dangerous weather, while on debug you won't receive a message telling you the weather has changed.

@Kamejeir
Copy link
Contributor Author

In case I'm understanding, this will make it so you don't receive messages while in the debug state. What if you do require receiving those messages for testing the thing, though? Such as when testing a dangerous weather, while on debug you won't receive a message telling you the weather has changed.

You can toggle them back on in the Distractions manager menu.

@kevingranade
Copy link
Member

This is entirely too opinionated and unexpected, a single menu entry to clear all distractions would be fine though.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 25, 2024
@Kamejeir Kamejeir deleted the quicksetup-distractions branch October 25, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants