Add aqua test #896
Merged
Add aqua test #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/aqua
branch
from
3fbac60 to
fa47013
Compare
bors bot
added a commit
that referenced
this pull request
Oct 5, 2022
900: Add and fix some Aqua tests r=charleskawczynski a=charleskawczynski This is a peel off from #896, which first adds and tackles the unbound type parameters Co-authored-by: Charles Kawczynski <[email protected]>
|
Oof, TC is a major offender. I may have an idea of how to fix this. Basically, we're running into lack of support for (compactly) indexing into vertical columns (CliMA/ClimaCore.jl#66) |
charleskawczynski
force-pushed
the
ck/aqua
branch
from
fa47013 to
d3f1697
Compare
charleskawczynski
force-pushed
the
ck/aqua
branch
from
d3f1697 to
99bf99c
Compare
|
I'll merge this for now and we can chip away at driving this down. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some aqua tests