Fix Aqua tests

src/DataLayouts/broadcast.jl

@@ -261,7 +261,7 @@ end
 function Base.similar(
     ::Union{IF{<:Any, Ni, A}, Broadcast.Broadcasted{IFStyle{Ni, A}}},
     ::Type{Eltype},
-) where {S, Ni, A, Eltype}
+) where {Ni, A, Eltype}
     Nf = typesize(eltype(A), Eltype)
     array = MArray{Tuple{Ni, Nf}, eltype(A), 2, Ni * Nf}(undef)
     return IF{Eltype, Ni}(array)
@@ -432,8 +432,8 @@ end
 
 function Base.copyto!(
     dest::IJFH{S, Nij},
-    bc::Union{IJFH{S, Nij}, Base.Broadcast.Broadcasted{IJFHStyle{Nij, A}}},
-) where {S, Nij, A}
+    bc::Union{IJFH{S, Nij}, Base.Broadcast.Broadcasted{<:IJFHStyle{Nij}}},
+) where {S, Nij}
     _, _, _, _, Nh = size(bc)
     @inbounds for h in 1:Nh
         slab_dest = slab(dest, h)
@@ -445,8 +445,8 @@ end
 
 function Base.copyto!(
     dest::IFH{S, Ni},
-    bc::Union{IFH{S, Ni}, Base.Broadcast.Broadcasted{IFHStyle{Ni, A}}},
-) where {S, Ni, A}
+    bc::Union{IFH{S, Ni}, Base.Broadcast.Broadcasted{<:IFHStyle{Ni}}},
+) where {S, Ni}
     _, _, _, _, Nh = size(bc)
     @inbounds for h in 1:Nh
         slab_dest = slab(dest, h)

src/Fields/field_iterator.jl

@@ -47,7 +47,6 @@ function isa_12_covariant_field(
     f::Type{CF},
 ) where {
     FT,
-    T,
     CF <: Geometry.AxisTensor{
         FT,
         1,
@@ -62,7 +61,6 @@ function isa_3_covariant_field(
     f::Type{CF},
 ) where {
     FT,
-    T,
     CF <: Geometry.AxisTensor{
         FT,
         1,

src/Geometry/axistensors.jl

@@ -288,8 +288,7 @@ end
 # LinearAlgebra
 
 check_axes(::A, ::A) where {A} = nothing
-check_axes(ax1, ax2) where {A} =
-    throw(DimensionMismatch("$ax1 and $ax2 do not match"))
+check_axes(ax1, ax2) = throw(DimensionMismatch("$ax1 and $ax2 do not match"))
 
 check_dual(ax1, ax2) = _check_dual(ax1, ax2, dual(ax2))
 _check_dual(::A, _, ::A) where {A} = nothing

src/Operators/stencilcoefs.jl

@@ -9,7 +9,7 @@ struct StencilCoefs{lbw, ubw, C <: NTuple}
     coefs::C
 end
 
-function StencilCoefs{lbw, ubw}(coefs::NTuple{N, T}) where {lbw, ubw, N, T}
+function StencilCoefs{lbw, ubw}(coefs::NTuple{N}) where {lbw, ubw, N}
     if !(
         (lbw isa Integer && ubw isa Integer) ||
         (lbw isa PlusHalf && ubw isa PlusHalf)
@@ -23,6 +23,7 @@ function StencilCoefs{lbw, ubw}(coefs::NTuple{N, T}) where {lbw, ubw, N, T}
     if N == 0 # no reason to support edge case of an empty stencil
         error("Stencil cannot be empty")
     end
+    T = eltype(coefs)
     if !isconcretetype(T) # must be compatible with DataLayouts
         error("Stencil coefficients must all have the same concrete type")
     end

src/Spaces/Spaces.jl

@@ -38,4 +38,7 @@ include("hybrid.jl")
 include("triangulation.jl")
 include("dss.jl")
 
+horizontal_space(space::ExtrudedFiniteDifferenceSpace) = space.horizontal_space
+horizontal_space(space::AbstractSpace) = space.topology
+
 end # module

src/Spaces/dss.jl

@@ -691,14 +691,27 @@ Create the ghost buffer, if necessary, load the send buffer and start communicat
 
 Part of [`Spaces.weighted_dss!`](@ref).
 """
-function weighted_dss_start!(
+weighted_dss_start!(data, space, ghost_buffer) =
+    weighted_dss_start!(data, space, horizontal_space(space), ghost_buffer)
+
+weighted_dss_start!(
+    data,
+    space::ExtrudedFiniteDifferenceSpace{S, H},
+    hspace::H,
+    ghost_buffer,
+) where {S, H <: SpectralElementSpace2D{<:DistributedTopology2D}} =
+    _weighted_dss_start!(data, space, hspace, ghost_buffer)
+
+weighted_dss_start!(
     data,
-    space::Union{ExtrudedFiniteDifferenceSpace{S, H}, H},
+    space::H,
+    hspace::H,
     ghost_buffer,
-) where {S, T <: DistributedTopology2D, H <: SpectralElementSpace2D{T}}
-    topology =
-        space isa ExtrudedFiniteDifferenceSpace ?
-        space.horizontal_space.topology : space.topology
+) where {H <: SpectralElementSpace2D{<:DistributedTopology2D}} =
+    _weighted_dss_start!(data, space, hspace, ghost_buffer)
+
+function _weighted_dss_start!(data, space, hspace, ghost_buffer)
+    topology = hspace.topology
     if ghost_buffer isa GhostBuffer
         # 1) copy send data to buffer
         fill_send_buffer!(topology, data, ghost_buffer)
@@ -708,7 +721,7 @@ function weighted_dss_start!(
     return nothing
 end
 
-function weighted_dss_start!(data, space, ghost_buffer)
+function weighted_dss_start!(data, space, hspace, ghost_buffer)
     return nothing
 end
 
@@ -747,11 +760,28 @@ Complete communication. Perform weighted dss for ghost faces and vertices.
 
 Part of [`Spaces.weighted_dss!`](@ref).
 """
+weighted_dss_ghost!(data, space, ghost_buffer) =
+    weighted_dss_ghost!(data, space, horizontal_space(space), ghost_buffer)
+
 function weighted_dss_ghost!(
     data,
-    space::Union{ExtrudedFiniteDifferenceSpace{S, H}, H},
+    space::ExtrudedFiniteDifferenceSpace{S, H},
+    hspace::H,
     ghost_buffer,
-) where {S, T <: DistributedTopology2D, H <: SpectralElementSpace2D{T}}
+) where {S, H <: SpectralElementSpace2D{<:DistributedTopology2D}}
+    _weighted_dss_ghost!(data, space, hspace, hspace, ghost_buffer)
+end
+
+function weighted_dss_ghost!(
+    data,
+    space::H,
+    hspace::H,
+    ghost_buffer,
+) where {H <: SpectralElementSpace2D{<:DistributedTopology2D}}
+    _weighted_dss_ghost!(data, space, hspace, hspace, ghost_buffer)
+end
+
+function _weighted_dss_ghost!(data, space, hspace, ghost_buffer)
     hspace =
         space isa ExtrudedFiniteDifferenceSpace ? space.horizontal_space : space
     topology = hspace.topology
@@ -793,6 +823,6 @@ function weighted_dss_ghost!(
     return data
 end
 
-function weighted_dss_ghost!(data, space, ghost_buffer)
+function weighted_dss_ghost!(data, space, hspace, ghost_buffer)
     return data
 end

test/aqua.jl

@@ -5,6 +5,8 @@ using Aqua
 @testset "Aqua tests - unbound args" begin
     # This tests that we don't accidentally run into
     # https://github.com/JuliaLang/julia/issues/29393
-    # ua = Aqua.detect_unbound_args_recursively(ClimaCore)
     Aqua.test_unbound_args(ClimaCore)
+
+    # returns a vector of all unbound args
+    # ua = Aqua.detect_unbound_args_recursively(ClimaCore)
 end