Improve limiter debug info, update deformation flow example and buffers #2152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR debugs the deformation flow example, which broke in this build (and is broken on main). So, this PR is effectively fixing CI. Closes #2151.
I've updated the way that the logging works for the limiters:
This test has been somewhat flaky for a while, and debugging has been challenging because the log is very bloated with false-positive warnings. The flakiness could be related to CliMA/ClimaTimeSteppers.jl#283, but I'm not sure. Ultimately, I think we need to add more precise / granular unit tests.
This PR should not be behavior changing, but I would like to, at some point, short-circuit the iteration loop in the limiters when the tracer mass (and some other variables) are zero, which results in relative error of NaNs / non-convergence warnings.