Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve limiter debug info, update deformation flow example and buffers #2152

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Jan 22, 2025

This PR debugs the deformation flow example, which broke in this build (and is broken on main). So, this PR is effectively fixing CI. Closes #2151.

I've updated the way that the logging works for the limiters:

  • This PR collects convergence statistics in the QuasimonotoneLimiter, and provides users with functions to print that information. This will alleviate log bloat, and give users better information for debugging.
  • The convergence stats are only supported for cpu jobs, since this requires using mutable structs. Perhaps there's a way we can still do this for gpu jobs, but that will require a very different looking solution, which is not the purpose of this PR.

This test has been somewhat flaky for a while, and debugging has been challenging because the log is very bloated with false-positive warnings. The flakiness could be related to CliMA/ClimaTimeSteppers.jl#283, but I'm not sure. Ultimately, I think we need to add more precise / granular unit tests.

This PR should not be behavior changing, but I would like to, at some point, short-circuit the iteration loop in the limiters when the tracer mass (and some other variables) are zero, which results in relative error of NaNs / non-convergence warnings.

@charleskawczynski charleskawczynski added the CI Issues releated to CI label Jan 22, 2025
@charleskawczynski charleskawczynski force-pushed the ck/fix_ci branch 2 times, most recently from 26776c3 to f6b5180 Compare January 22, 2025 17:52
@charleskawczynski charleskawczynski marked this pull request as ready for review January 22, 2025 17:57
@charleskawczynski charleskawczynski force-pushed the ck/fix_ci branch 2 times, most recently from d2c5e98 to b1131a0 Compare January 23, 2025 14:47
@charleskawczynski charleskawczynski changed the title Debug deformation flow example Improve limiter debug info, update deformation flow example and buffers Jan 23, 2025
@charleskawczynski charleskawczynski force-pushed the ck/fix_ci branch 3 times, most recently from 969e022 to 259a13a Compare January 23, 2025 20:36
@charleskawczynski charleskawczynski removed the request for review from szy21 January 23, 2025 20:38
@charleskawczynski charleskawczynski merged commit 309116f into main Jan 24, 2025
35 checks passed
@charleskawczynski charleskawczynski deleted the ck/fix_ci branch January 24, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues releated to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deformation flow with limiter broke in CI
1 participant