Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Ksat as ic #1021

Merged
merged 1 commit into from
Feb 10, 2025
Merged

use Ksat as ic #1021

merged 1 commit into from
Feb 10, 2025

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Feb 10, 2025

Purpose

We established that #993 introduced NaNs into the simulation, and that reverting the runoff change fixes them.

This PR reverts the runoff changes.

@kmdeck kmdeck marked this pull request as ready for review February 10, 2025 19:29
@kmdeck kmdeck requested a review from juliasloan25 February 10, 2025 19:29
@kmdeck kmdeck force-pushed the kd/long_runs_runoff_revert branch from 46848e1 to ab64a2a Compare February 10, 2025 19:30
@kmdeck kmdeck force-pushed the kd/long_runs_runoff_revert branch from ab64a2a to 3d1411d Compare February 10, 2025 19:54
@kmdeck kmdeck enabled auto-merge (squash) February 10, 2025 19:54
@kmdeck kmdeck merged commit 3be9828 into main Feb 10, 2025
16 of 17 checks passed
@kmdeck kmdeck deleted the kd/long_runs_runoff_revert branch February 10, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants