Reduce allocations #967
Open
Reduce allocations #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/allocations
branch
3 times, most recently
from
7c32282 to
9c0c61a
Compare
Sbozzolo
force-pushed
the
gb/allocations
branch
14 times, most recently
from
d6fb842 to
dabcb52
Compare
Sbozzolo
force-pushed
the
gb/allocations
branch
5 times, most recently
from
91d014d to
fbe6886
Compare
kmdeck
reviewed
Jan 7, 2025
kmdeck
reviewed
Jan 7, 2025
kmdeck
reviewed
Jan 7, 2025
kmdeck
reviewed
Jan 7, 2025
|
also, if you dont mind, you can assign me an issue re dealing with the snow specific humidity allocation and the allocation in HydrologyEarthParameters |
JULIA_CUDA_MEMORY_POOL="none" disables the CUDA memory pool. This is required for MPI runs with certain versions of MPI, but it hurts performance
Sbozzolo
force-pushed
the
gb/allocations
branch
3 times, most recently
from
4f63af6 to
a74687b
Compare
This commit reduces allocations by changing turbulent_fluxes and net_radiation to be in place. In addition to this, the workaround introduced to enable GPU-compatibility in energy_hydrology resulted in lots of additional allocations, so I modified that too. There are still allocations. One of the easy ones to tackle is in surface_specificy_humidity for snow, which accounts for a large fraction of the total allocations for the snowy_land benchmark
Sbozzolo
force-pushed
the
gb/allocations
branch
from
a74687b to
1822266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reduces allocations by changing turbulent_fluxes and net_radiation to be in place. In addition to this, the workaround introduced to enable GPU-compatibility in energy_hydrology resulted in lots of additional allocations, so I modified that too.
These allocations are due to the fact that there are broadcasted expression hidden in simple function calls, so that Julia cannot properly do operations in place.
There are still allocations. One of the easy ones to tackle is in surface_specificy_humidity for snow, which accounts for a large fraction of the total allocations for the snowy_land benchmark.
Closes #966