add state NaN checker #970
Open
+240
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/check-nans
branch
2 times, most recently
from
8a8e505 to
39a4e0e
Compare
Adds a function that quantitatively checks how many NaNs are present in the state, and displays this information to the user. This can be used to inspect sol.u[end] after a simulation has run, to see if any NaNs were produced at the end of the simulation. If no NaNs are found, this information is logged in an info statement. If NaNs are found, this information is logged in a warn statement.
juliasloan25
force-pushed
the
js/check-nans
branch
from
39a4e0e to
49206ad
Compare
kmdeck
reviewed
Jan 6, 2025
src/shared_utilities/utils.jl
Outdated
| return nothing | ||
| end | ||
|
|
||
| function count_nans_state(state::ClimaCore.Fields.Field) |
There was a problem hiding this comment.
would we like to make this also take the land mask as a second argument?
kmdeck
reviewed
Jan 6, 2025
juliasloan25
force-pushed
the
js/check-nans
branch
from
dcec968 to
42d41d2
Compare
Sbozzolo
reviewed
Jan 6, 2025
src/shared_utilities/utils.jl
Outdated
Comment on lines
513
to
524
| for pn in propertynames(state) | ||
| state_new = getproperty(state, pn) | ||
| @info "Checking NaNs in $pn" | ||
| count_nans_state(state_new, mask) | ||
| end |
There was a problem hiding this comment.
Maybe
any(isnan, state)works
juliasloan25
force-pushed
the
js/check-nans
branch
from
42d41d2 to
27d961f
Compare
juliasloan25
force-pushed
the
js/check-nans
branch
from
27d961f to
a5fffc5
Compare
juliasloan25
force-pushed
the
js/check-nans
branch
from
a5fffc5 to
bba26da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes #969
Adds a function that quantitatively checks how many NaNs are present in the state, and displays this information to the user. This can be used to inspect
sol.u[end]after a simulation has run, to see if any NaNs were produced at the end of the simulation.If no NaNs are found, this information is logged in an
infostatement. If NaNs are found, this information is logged in awarnstatement.To-do