Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MODIS LAI driver & use in snowy land benchmark #973

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Espeer5
Copy link
Collaborator

@Espeer5 Espeer5 commented Jan 6, 2025

Purpose

This PR adds driver utilities to run simulations using MODIS LAI from 2008 as opposed to era5 LAI. Corresponding PR adding MODIS LAI data to ClimaArtifacts is here.

To-do

  • Verify MODIS LAI works correctly where used in snowy land benchmark
  • Clarify which experiments/benchmarks should use MODIS LAI by default

Content

  • MODIS LAI artifact added to Artifacts.toml
  • Utility to get the MODIS LAI artifact path added to src/Artifacts.jl
  • Utility to construct the LAI function from MODIS LAI data added to drivers.jl

  • I have read and checked the items on the review checklist.

@Espeer5 Espeer5 self-assigned this Jan 6, 2025
# joinpath(era5_lai_artifact_path, "era5_2008_1.0x1.0_lai.nc")
modis_lai_ncdata_path =
joinpath(modis_lai_artifact_path, "Yuan_et_al_2011_1x1.nc")
# LAIfunction = ClimaLand.prescribed_lai_era5(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I opted to leave these changes very clearly temporary - I'm not sure whether we want to change certain runs to use MODIS, or all of them, or none of them. The main point for now was just to test that the format of the data is all correct and it will run the experiment correctly on the buildkite runs.

@kmdeck kmdeck added the Run benchmarks Add this label to run benchmarks on clima label Jan 6, 2025
@kmdeck
Copy link
Member

kmdeck commented Jan 6, 2025

A note - we dont run the benchmarks by default (or the long runs). You need to add the label to the PR, and then make a push to the branch to trigger them. it's a little annoying but better than running them every time

@Espeer5
Copy link
Collaborator Author

Espeer5 commented Jan 7, 2025

I'm really not sure what's happening with the buildkite here - no changes to the manifest or anything so I don't know why there are so many failures in the packages/includes/imports?

@kmdeck
Copy link
Member

kmdeck commented Jan 7, 2025

I'm really not sure what's happening with the buildkite here - no changes to the manifest or anything so I don't know why there are so many failures in the packages/includes/imports?

I had trouble today too, and cleared the depot. I tried rebuilding here - let's see if it runs now

@Espeer5
Copy link
Collaborator Author

Espeer5 commented Jan 8, 2025

I'm really not sure what's happening with the buildkite here - no changes to the manifest or anything so I don't know why there are so many failures in the packages/includes/imports?

I had trouble today too, and cleared the depot. I tried rebuilding here - let's see if it runs now

Thank you, this worked!

I believe that incorporating the MODIS LAI seems to have worked correctly - there are certainly differences in the two input datasets though. From our global run plots, here is the LAI from MODIS:
image

Vs from ERA5:
image

It's just generally lower than ERA5, with the difference being quite extreme across the northern hemisphere.

@Espeer5 Espeer5 added Run long runs and removed Run benchmarks Add this label to run benchmarks on clima labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants