-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MODIS LAI driver & use in snowy land benchmark #973
base: main
Are you sure you want to change the base?
Conversation
experiments/benchmarks/snowy_land.jl
Outdated
# joinpath(era5_lai_artifact_path, "era5_2008_1.0x1.0_lai.nc") | ||
modis_lai_ncdata_path = | ||
joinpath(modis_lai_artifact_path, "Yuan_et_al_2011_1x1.nc") | ||
# LAIfunction = ClimaLand.prescribed_lai_era5( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I opted to leave these changes very clearly temporary - I'm not sure whether we want to change certain runs to use MODIS, or all of them, or none of them. The main point for now was just to test that the format of the data is all correct and it will run the experiment correctly on the buildkite runs.
A note - we dont run the benchmarks by default (or the long runs). You need to add the label to the PR, and then make a push to the branch to trigger them. it's a little annoying but better than running them every time |
I'm really not sure what's happening with the buildkite here - no changes to the manifest or anything so I don't know why there are so many failures in the packages/includes/imports? |
I had trouble today too, and cleared the depot. I tried rebuilding here - let's see if it runs now |
Purpose
This PR adds driver utilities to run simulations using MODIS LAI from 2008 as opposed to era5 LAI. Corresponding PR adding MODIS LAI data to ClimaArtifacts is here.
To-do
Content