Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.3.0) Cleaner syntax for ECCOFieldTimeSeries and ECCORestoring #284

Merged
merged 19 commits into from
Dec 14, 2024

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Dec 2, 2024

Closes #231

@glwagner
Copy link
Member Author

glwagner commented Dec 2, 2024

It's still kind of confusing how ECCORestoring takes both an arch and grid to me

@navidcy
Copy link
Collaborator

navidcy commented Dec 2, 2024

It's still kind of confusing how ECCORestoring takes both an arch and grid to me

Agree 👍🏼
#231

@glwagner
Copy link
Member Author

glwagner commented Dec 2, 2024

Ok, I will clean up ECCORestoring here as well

@glwagner glwagner changed the title Cleaner syntax for ECCOFieldTimeSeries Cleaner syntax for ECCOFieldTimeSeries and ECCORestoring Dec 2, 2024
@glwagner
Copy link
Member Author

glwagner commented Dec 2, 2024

Still TODO here is to clean up the constructor for ECCORestoring, but I plan to do this along the same lines as the one for ECCOFieldTimeSeries

@glwagner glwagner mentioned this pull request Dec 5, 2024
@glwagner glwagner changed the title Cleaner syntax for ECCOFieldTimeSeries and ECCORestoring (0.3.0) Cleaner syntax for ECCOFieldTimeSeries and ECCORestoring Dec 5, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (0c91ba6) to head (180fefa).

Files with missing lines Patch % Lines
src/DataWrangling/ECCO/ECCO_restoring.jl 0.00% 23 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #284   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         34      34           
  Lines       1953    1951    -2     
=====================================
+ Misses      1953    1951    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glwagner glwagner merged commit a193aee into main Dec 14, 2024
20 checks passed
@glwagner glwagner deleted the glw/ecco-fts branch December 14, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECCORestoring method accepts architecture and grid; validation required?
3 participants