-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Enzyme test for differentiating a single column model with CATKEVerticalDiffusivity #3837
base: main
Are you sure you want to change the base?
Conversation
Stuck with this error:
|
…com/CliMA/Oceananigans.jl into glw/autodiff-hydrostatic-turbulence
…nce' into glw/enzyme-scm
…s.jl into glw/enzyme-scm
function fill_halo_regions!(catke_diffusivity_fields::CATKEDiffusivityFields, args...; kw...) | ||
fill_halo_regions!(catke_diffusivity_fields.κu, args...; kw...) | ||
fill_halo_regions!(catke_diffusivity_fields.κc, args...; kw...) | ||
fill_halo_regions!(catke_diffusivity_fields.κe, args...; kw...) | ||
return nothing | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fill halos can be tupled up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
touche
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to say, the reason not to do this is that we've had some issues differentiating through the tupling code which previously was type unstable. So the whole reason to put this here was to avoid that. Neverthless we should be able to make it work, I'l try
No description provided.